"Open in new tab" on .crm-summary-link icons should open contact page #22303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
braders
force-pushed
the
core-2926-crm-summary-links
branch
from
ad79908 to
14b5522
Compare
|
jenkins retest this please - weird fail |
…, not summary content. Whilst the contact image tooltip is set to preventDefault, it is still possible to copy the URL or open in new tab. This change ensures that the correct URL is set in these situations. Backwards compatiability is retained for third parties using the crm-tooltip class without the new data attribute.
braders
force-pushed
the
core-2926-crm-summary-links
branch
from
14b5522 to
2ba5b7f
Compare
demeritcowboy
added
the
merge ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.
](https://lab.civicrm.org/dev/core/-/issues/2926
Whilst the contact image tooltip is set to preventDefault, it is still possible to copy the URL or open in new tab.
This change ensures that the correct URL is set in these situations.
Before
When searching for contacts (as well as in some other contexts) each contact has a contact-type icon which shows some extra details on hover. Right-clicking on the contact-type icon and either copying the link or opening in a new tab resulted in the popup (tooltip) contents loading as a standalone page.
After
Right-clicking on the contact-type icon and either copying the link or opening in a new tab results in the contact CRM page opening, instead of the tooltip contents. There is no change to normal usage.
Comments
Backwards compatiability is retained for third parties using the crm-tooltip class without the new data attribute.